fix: retry writing traced files if there are conflicts #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 64.08% 63.75% -0.33%
==========================================
Files 55 55
Lines 3653 3656 +3
Branches 403 404 +1
==========================================
- Hits 2341 2331 -10
- Misses 1298 1309 +11
- Partials 14 16 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pi0
reviewed
Oct 12, 2022
| let error: any | ||
| while (retry++ < retries) { | ||
| try { return await fn() } catch (err) { | ||
| error = err |
There was a problem hiding this comment.
We might always show error as warning. If it is happening too often not hiding the issue.
WinterYukky
pushed a commit
to WinterYukky/nitro
that referenced
this pull request
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #536
β Type of change
π Description
It seems that when multiple traced files in the same directory are copied on windows, in some circumstances, we have a race condition which causes a 'resource busy or locked' error. It's possible this is very much an edge case, such as when testing. But this change seems safe; it adds a small 2ms timeout and will retry a file up to 3 times, which will hopefully reduce any flakiness. I've confirmed (with
yarn patch) that it does resolve the issue in framework repo.(Another option would be synchronous file copying.)
π Checklist